[WC-3052] DataWidget: Styling variables cleanup #1839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjulivan
reviewed
Aug 15, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/variables.scss
Show resolved
Hide resolved
yordan-st
force-pushed
the
feat/WC-3052_datawidget-styling-variables-cleanup
branch
2 times, most recently
from
892cbfb to
bc53cd1
Compare
gjulivan
previously approved these changes
Aug 19, 2025
gjulivan
force-pushed
the
feat/WC-3052_datawidget-styling-variables-cleanup
branch
from
bc53cd1 to
e462bc5
Compare
gjulivan
force-pushed
the
feat/WC-3052_datawidget-styling-variables-cleanup
branch
2 times, most recently
from
951b721 to
e7c3d97
Compare
samuelreichert
previously approved these changes
Sep 9, 2025
gjulivan
dismissed stale reviews from samuelreichert and themself
via
0071651
leonardomendix
previously approved these changes
Sep 9, 2025
gjulivan
force-pushed
the
feat/WC-3052_datawidget-styling-variables-cleanup
branch
from
0071651 to
4993eec
Compare
gjulivan
reviewed
Sep 10, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/variables.scss
Outdated
Show resolved
Hide resolved
yordan-st
force-pushed
the
feat/WC-3052_datawidget-styling-variables-cleanup
branch
from
4993eec to
50dffae
Compare
gjulivan
reviewed
Sep 10, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid-design-properties.scss
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Sep 10, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid-design-properties.scss
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Sep 10, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid-filters.scss
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Sep 10, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid-filters.scss
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Sep 10, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid-filters.scss
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Sep 10, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid-filters.scss
Outdated
Show resolved
Hide resolved
gjulivan
previously approved these changes
Sep 11, 2025
yordan-st
force-pushed
the
feat/WC-3052_datawidget-styling-variables-cleanup
branch
from
1744a9a to
a646b7c
Compare
yordan-st
force-pushed
the
feat/WC-3052_datawidget-styling-variables-cleanup
branch
from
a646b7c to
34157be
Compare
gjulivan
force-pushed
the
feat/WC-3052_datawidget-styling-variables-cleanup
branch
from
34157be to
d60dc6d
Compare
gjulivan
previously approved these changes
Sep 11, 2025
yordan-st
force-pushed
the
feat/WC-3052_datawidget-styling-variables-cleanup
branch
from
d60dc6d to
b04b84b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Refactoring (e.g. file rename, variable rename, etc.)
Description
Consolidated all SCSS variables from individual files into
variables.scssto eliminate duplicates and create a single source of truth for theming, adding !default flags for easier overrides.What should be covered while testing?